m
Member
Hello Prit,
Just notice a possible issue with the programming for the RSS feeder. The first link listed in the feed (link to the blog home page) ends with a period, causing the link to not work (404 error). The link looks like "http://www.yoursite.com/blog/index." and at least with my setup returns a 404 error when visited. If the period after "index" was removed, the link would work fine.
Prit
Pritlogger
Thanks for reporting. I will take a look.
halojoy
Member
I managed to get 100% valid RSS with Pritlog!
There was an issue when using 'åäö' in <title> of RSS item.
Also was lacking <atom:link> and <guid></guid>.
Validator: http://feedvalidator.org/
This is my working fixed RSS function:
function createRSS() {
global $config, $separator, $entries, $optionValue, $lang;
$base = 'http://'.$_SERVER['HTTP_HOST'].substr($_SERVER['REQUEST_URI'],0,-3);
echo header('Content-type: text/xml').'<?xml version="1.0" encoding="ISO-8859-1"?><rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">';
echo '<channel><title>'.$config['blogTitle'].'</title><description>'.$config['metaDescription'].'</description>';
echo '<link>http://'.$_SERVER['HTTP_HOST'].substr($_SERVER['REQUEST_URI'],0,strlen($_SERVER['REQUEST_URI'])-7).'</link>';
echo '<atom:link href="'.$base.'RSS" rel="self" type="application/rss+xml" />';
$result = sqlite_query($config['db'], "select count(postid) AS view from posts WHERE type = 'post';");
while ($row = sqlite_fetch_array($result, SQLITE_ASSOC)) {
$totalEntries = $row['view'];
}
if($config['entriesOnRSS'] == 0)
{
$limit = $totalEntries;
}
else
{
$limit = $config['entriesOnRSS'];
}
$limit = ($limit > 200) ? 200 : $limit;
$result = sqlite_query($config['db'], "select * from posts ORDER BY postid DESC LIMIT $limit;");
while ($row = sqlite_fetch_array($result, SQLITE_ASSOC)) {
$rssTitle = $row['title'];
$rssTitleModified=titleModify($rssTitle);
$rssContent = explode("*readmore*",$row['content']);
if (trim($rssContent[1]) !== "") $readmore = '
'.$lang['pageViewFullPost'].'';
else $readmore = "";
$date1 = $row['date'];
$rssEntry = $row['postid'];
$rssCategory = $row['category'];
$postType = $row['type'];
$allowComments = $row['allowcomments'];
$visits = $row['visits'];
$link = $base.htmlspecialchars('posts/'.$rssEntry."/".$rssTitleModified);
if (trim($visits) == "") { $visits=0; }
if ($optionValue === $rssCategory || trim($optionValue) == "") {
echo '<item><link>'.$link.'</link>';
echo '<title>'.html_entity_decode($rssTitle).'</title><category>'.$rssCategory.'</category>';
echo '<description>'.htmlspecialchars(html_entity_decode($rssContent[0].$readmore)).'</description><guid>'.$link.'</guid></item>';
//echo '<description>'.htmlspecialchars($rssContent[0]).'
'.$lang['pageViewFullPost'].'</description></item>';
}
}
echo '</channel></rss>';
}
halojoy
Member
My new valid and corrected function createRSS()
$link = ... must be BEFORE .... $readmore
function createRSS() {
global $config, $separator, $entries, $optionValue, $lang;
$base = 'http://'.$_SERVER['HTTP_HOST'].substr($_SERVER['REQUEST_URI'],0,-4);
echo header('Content-type: text/xml').'<?xml version="1.0" encoding="ISO-8859-1"?>'."\n";
echo '<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">'."\n";
echo '<channel>'."\n".'<title>'.$config['blogTitle'].'</title>'."\n";
echo '<description>'.$config['metaDescription'].'</description>'."\n";
echo '<link>'.$base.'</link>'."\n";
echo '<atom:link href="'.$base.'/RSS" rel="self" type="application/rss+xml" />'."\n";
$result = sqlite_query($config['db'], "select count(postid) AS view from posts WHERE type = 'post';");
while ($row = sqlite_fetch_array($result, SQLITE_ASSOC)) {
$totalEntries = $row['view'];
}
if($config['entriesOnRSS'] == 0){
$limit = $totalEntries;
}else{
$limit = $config['entriesOnRSS'];
}
$limit = ($limit > 200) ? 200 : $limit;
$result = sqlite_query($config['db'], "select * from posts ORDER BY postid DESC LIMIT $limit;");
while ($row = sqlite_fetch_array($result, SQLITE_ASSOC)) {
$rssTitle = $row['title'];
$rssTitleModified=titleModify($rssTitle);
$date1 = $row['date'];
$rssEntry = $row['postid'];
$link = $base.htmlspecialchars('/posts/'.$rssEntry."/".$rssTitleModified);
$rssContent = explode("*readmore*",$row['content']);
$readmore = "";
if (trim($rssContent[1]) !== "")
$readmore = '<br /><br /><a href="'.$link.'">'.$lang['pageViewFullPost'].'</a>';
$rssCategory = $row['category'];
$postType = $row['type'];
$allowComments = $row['allowcomments'];
$visits = $row['visits'];
if (trim($visits) == "") { $visits=0; }
if ($optionValue === $rssCategory || trim($optionValue) == "") {
echo '<item>'."\n".' <link>'.$link.'</link>'."\n";
echo ' <title>'.html_entity_decode($rssTitle).'</title>'."\n";
echo ' <category>'.$rssCategory.'</category>'."\n";
echo ' <description>'.htmlspecialchars(html_entity_decode($rssContent[0].$readmore)).'</description>'."\n";
echo ' <guid isPermaLink="true">'.$link.'</guid>'."\n".'</item>'."\n";
}
}
echo '</channel>'."\n".'</rss>';
}
halojoy
Member
I recommend the following link to validate RSS:
http://www.validome.org/rss-atom/validate
Because it is possible to 'View Sourcecode' output.
For validation and an image 'ValidRSS' to put on your Pritlog
I can recommend this validator:
http://feedvalidator.org/
Regards
Prit
Pritlogger
Thanks for your comments. I have started to work on the next release of Pritlog. Will see if these can be implemented.
chill
Member
Hi Prit,
I'm having the same problems with the RSS feature too. I'm upgraded to 0.811. For whatever reason, my index page is starting on line four instead of line one. And, I cannot figure out "for the life of me" why this is happening. I think the line start has something to do with the RSS feature not working for the "Subscribe to this page.." icon in the URL and the RSS Feeds link in the right menu.
This is what the Feed Validator shows me for my RSS:
Source: http://chills.myedublog.com/index.php/RSS
1.
2.
3.
4. <?xml version="1.0" encoding="ISO-8859-1"?><rss version="2.0"><channel><title>Mr. Hill's Educational Blog</title><description>Mr. Hill - A K12 Web Blogger</description><link>http://chills.myedublog.com/index.</link></channel></rss>
I checked the index.php, the header.tpl, the main.tpl and the .tpl files in the blocks sub directory and none of them start on line 4. I see that halojoy has provided some code for the fix, but I don't know exactly what I should use since it doesn't look like it is the code for version 0.811.
I sure would appreciate the help.
Regards,
Charles
P.S. - The demo at http://demo.opensourcecms.com/pritlog/ is displaying these errors:
Warning: sqlite_query() [function.sqlite-query]: attempt to write a readonly database in /home/opencms/public_html/demo/pritlog/index.php on line 2368
Warning: sqlite_query() [function.sqlite-query]: attempt to write a readonly database in /home/opencms/public_html/demo/pritlog/index.php on line 2402
And, the RSS feature is not working for the "Subscribe to this page.." icon in the URL, but the RSS Feeds link in the right menu is working.
You must log in to post.